Skip to content

feat: Add AL2023 ARM64 NVIDIA variants #3369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

feat: Add AL2023 ARM64 NVIDIA variants #3369

merged 1 commit into from
Jun 9, 2025

Conversation

ndbaker1
Copy link
Contributor

Description

Add support for the AL2023 ARM64 NVIDIA variants

Motivation and Context

allow users to deploy this variant, based on the instructions in https://docs.aws.amazon.com/eks/latest/userguide/retrieve-ami-id.html

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

additions to enums, SSM paths are validated

> aws ssm get-parameter --name /aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/image_id
{
    "Parameter": {
        "Name": "/aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/image_id",
        "Type": "String",
        "Value": "ami-022ceb29ab1ee37d6",
        "Version": 7,
        "LastModifiedDate": "2025-05-22T00:35:45.511000+00:00",
        "ARN": "arn:aws:ssm:us-west-2::parameter/aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/image_id",
        "DataType": "text"
    }
}

> aws ssm get-parameter --name /aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/release_version
{
    "Parameter": {
        "Name": "/aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/release_version",
        "Type": "String",
        "Value": "1.32.3-20250519",
        "Version": 7,
        "LastModifiedDate": "2025-05-22T00:35:45.427000+00:00",
        "ARN": "arn:aws:ssm:us-west-2::parameter/aws/service/eks/optimized-ami/1.32/amazon-linux-2023/arm64/nvidia/recommended/release_version",
        "DataType": "text"
    }
}

bryantbiggs
bryantbiggs approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs
Copy link
Member

@ndbaker1 do you know when AL2023_ARM_64_NVIDIA will be added to the API as a supported AMI type? I don't see it here yet https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-nodegroup.html#aws-resource-eks-nodegroup-properties

@ndbaker1
Copy link
Contributor Author

Checking on this, seems like a part of the push is still held up

@bryantbiggs
Copy link
Member

looks like this variant is now shown in the API, merging

image

@bryantbiggs bryantbiggs merged commit 715d42b into terraform-aws-modules:master Jun 9, 2025
22 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 9, 2025
@semantic-release-bot
chore(release): version 20.37.0 [skip ci]
a9c659a 
## [20.37.0](v20.36.1...v20.37.0) (2025-06-09)

### Features

* Add AL2023 ARM64 NVIDIA variants ([#3369](#3369)) ([715d42b](715d42b))
@antonbabenko
Copy link
Member

This PR is included in version 20.37.0 🎉

@ndbaker1 ndbaker1 deleted the al2023-arm64-nvidia branch June 10, 2025 01:48
@kappa8219
Copy link

Now g5g.* are coming into play. Thanks!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ndbaker1 @bryantbiggs @antonbabenko @kappa8219